Conversation
Added a header comment for Home Assistant addon definition.
…ome-assistant Add Home Assistant add-on repository support and clarify HA config path
| @@ -0,0 +1,3 @@ | |||
| name: MieleRESTServer Home Assistant Add-ons | |||
| url: 'https://github.com/hannesdelbeke/MieleRESTServer' | |||
There was a problem hiding this comment.
| url: 'https://github.com/hannesdelbeke/MieleRESTServer' | |
| url: 'https://github.com/akappner/MieleRESTServer' |
There was a problem hiding this comment.
once i change this you wont be able to test it in HA until this is merged i think
| version: "1.1.1" | ||
| slug: miele_rest_server | ||
| description: Run MieleRESTServer as a Home Assistant add-on. | ||
| url: https://github.com/hannesdelbeke/MieleRESTServer |
There was a problem hiding this comment.
| url: https://github.com/hannesdelbeke/MieleRESTServer | |
| url: https://github.com/akappner/MieleRESTServer |
| exit 1; \ | ||
| fi \ | ||
| && pip3 install --break-system-packages --no-cache-dir \ | ||
| "https://github.com/hannesdelbeke/MieleRESTServer/archive/refs/heads/master.zip" |
There was a problem hiding this comment.
| "https://github.com/hannesdelbeke/MieleRESTServer/archive/refs/heads/master.zip" | |
| "https://github.com/akappner/MieleRESTServer/archive/refs/heads/master.zip" |
|
@pzbitskiy |
Hi @akappner. I gave this integration a try as I've been looking to move away from my own Dockerfile setup. It works to host the application which is nice. I had initially expected auto discovery, but that seems to not be the case. You still have to set it up as a REST sensor, but after I had done that I was able to see the machine attributes in HA without any issues |
| @@ -0,0 +1,21 @@ | |||
| ARG BUILD_FROM=ghcr.io/home-assistant/amd64-base:latest | |||
There was a problem hiding this comment.
This base image argument looks like it would only work for amd64, even though the config.yaml has aarch64
There was a problem hiding this comment.
could you have a look at the updates? should be addressed now.
I tested it still builds in HA
Co-authored-by: pzbitskiy <pavel.zbitskiy@gmail.com>
…rchitecture builds Fix Dockerfile: Remove default value from BUILD_FROM to support multi-architecture builds
Fix config.yaml: Add complete file with build_from section for multi-architecture support
ed28d91 to
1e2682c
Compare
|
|
Hi, |
|
I v not yet replaced the urls. Did you? If not it will build from my fork i stead of your repo |
|
Thanks for the reminder, I updated it. Has anybody tested this on ARM64? There's still some amd64 references in the HA-specific Dockerfile (in the BUILD_FROM variable) but it might just be a default that gets overwritten. |
Yes, I was able to install it (Apps -> Install App -> ... -> Repositories) from https://github.com/hannesdelbeke/MieleRESTServer as repository, on x86 server. Docker container started eb19bc3ad639 8003cb44/amd64-addon-miele_rest_server:1.1.1 "/init /app/run.sh" 2 seconds ago Up 1 second 0.0.0.0:5001->5001/tcp, [::]:5001->5001/tcp addon_8003cb44_miele_rest_serverbut exited seconds after with the following in the log (I have not tried to configure the stuff yet so I guess it is OK): Good stuff @hannesdelbeke ! |
|
Yeah, that behavior makes sense and isn't related to Docker/HACS. Without a config file, the server can't do anything useful so it exits. Give it a config file (or just copy the default) and it should work |

issue
current repo can't be added to HA from the UI
fix
added addon support and followed HA best practices.
now can install from the HA addon store, which builds the docker image on your HA instance
https://github.com/hannesdelbeke/MieleRESTServernote that this does need testing by someone else, since i haven't modded my washing machine yet.