Potential fix for code scanning alert no. 3: DOM text reinterpreted as HTML - #4
Merged
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/albert-mueller/albert-mueller.github.io/security/code-scanning/3
General fix: avoid interpreting untrusted text as HTML. Build DOM nodes programmatically and assign untrusted values via
textContentand safe DOM APIs (setAttribute, dataset, or direct property assignment), rather than string-building intoinnerHTML.Best fix for this code: in
others/translate/app.js, updateshowComparisonViewso both translation-option blocks are constructed withcreateElement,className,textContent, andbutton.setAttribute('data-translation', ...). This preserves existing behavior and layout while eliminating HTML parsing of tainted strings. Specifically replace the twoinnerHTML = \...`` regions (original translation and modified translation cards) with explicit node creation and appending.No new helper methods or imports are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.