Skip to content

Potential fix for code scanning alert no. 3: DOM text reinterpreted as HTML #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albert-mueller merged 1 commit into from
Aug 6, 2026
Merged

Potential fix for code scanning alert no. 3: DOM text reinterpreted as HTML #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions others/translate/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,13 +814,28 @@ async function showComparisonView(originalText, modifiedText, translation) {
const originalTranslation = document.createElement('div');
if (originalTranslation && originalTranslation.className !== undefined) {
originalTranslation.className = 'translation-option';
originalTranslation.innerHTML = `
<div class="option-header">
<div class="option-title">原始翻译</div>
<button class="use-translation" data-translation="${translation}">使用此翻译</button>
</div>
<div class="option-content">${translation}</div>
`;

const originalHeader = document.createElement('div');
originalHeader.className = 'option-header';

const originalTitle = document.createElement('div');
originalTitle.className = 'option-title';
originalTitle.textContent = '原始翻译';

const originalButton = document.createElement('button');
originalButton.className = 'use-translation';
originalButton.setAttribute('data-translation', translation);
originalButton.textContent = '使用此翻译';

originalHeader.appendChild(originalTitle);
originalHeader.appendChild(originalButton);

const originalContent = document.createElement('div');
originalContent.className = 'option-content';
originalContent.textContent = translation;

originalTranslation.appendChild(originalHeader);
originalTranslation.appendChild(originalContent);
comparisonContent.appendChild(originalTranslation);
} else {
console.warn('originalTranslation-Element oder dessen className-Attribut fehlt');
Expand All @@ -836,13 +851,28 @@ async function showComparisonView(originalText, modifiedText, translation) {
const modifiedTranslation = document.createElement('div');
if (modifiedTranslation && modifiedTranslation.className !== undefined) {
modifiedTranslation.className = 'translation-option';
modifiedTranslation.innerHTML = `
<div class="option-header">
<div class="option-title">近义词翻译</div>
<button class="use-translation" data-translation="${modifiedTranslationText}">使用此翻译</button>
</div>
<div class="option-content">${modifiedTranslationText}</div>
`;

const modifiedHeader = document.createElement('div');
modifiedHeader.className = 'option-header';

const modifiedTitle = document.createElement('div');
modifiedTitle.className = 'option-title';
modifiedTitle.textContent = '近义词翻译';

const modifiedButton = document.createElement('button');
modifiedButton.className = 'use-translation';
modifiedButton.setAttribute('data-translation', modifiedTranslationText);
modifiedButton.textContent = '使用此翻译';

modifiedHeader.appendChild(modifiedTitle);
modifiedHeader.appendChild(modifiedButton);

const modifiedContent = document.createElement('div');
modifiedContent.className = 'option-content';
modifiedContent.textContent = modifiedTranslationText;

modifiedTranslation.appendChild(modifiedHeader);
modifiedTranslation.appendChild(modifiedContent);
comparisonContent.appendChild(modifiedTranslation);
} else {
console.warn('modifiedTranslation-Element oder dessen className-Attribut fehlt');
Expand Down