Fix: XSS via unescaped innerHTML in translation history/favorites - #7
Merged
Conversation
…ry/favorites (XSS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
createHistoryItem()andcreateFavoriteItem()inothers/translate/app.jsinsertitem.sourceTextanditem.translationdirectly intoinnerHTMLwithout escaping. Both fields are user-controlled (typed input / translation output) and persisted tolocalStorage, then re-rendered on every visit to the History/Favorites panels. Text like<img src=x onerror=alert(1)>typed into the translator executes as script when the history entry is later rendered (stored XSS, CWE-79).Fix
Added an
escapeHtml()helper and applied it to both fields in both functions, matching thetextContent-based pattern already used safely elsewhere in this file (synonyms, dictionary, grammar, context panels).Scope
Single file,
others/translate/app.js. No behavior change besides escaping.