Skip to content

Fix: XSS via unescaped innerHTML in translation history/favorites #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albert-mueller merged 1 commit into from
Aug 7, 2026
Merged

Fix: XSS via unescaped innerHTML in translation history/favorites #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions others/translate/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@ let currentSynonyms = []; // 当前近义词列表
let selectedSynonym = null; // 选择的近义词
let translationQuality = 0; // 翻译质量评分

// Escaped für die sichere Einfügung nutzergesteuerter Texte via innerHTML (verhindert XSS)
function escapeHtml(str) {
if (str === null || str === undefined) return '';
return String(str)
.replace(/&/g, '&')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#39;');
}

// ===== DOM 元素 =====
document.addEventListener('DOMContentLoaded', function() {
// 获取DOM元素
Expand Down Expand Up @@ -1335,8 +1346,8 @@ function createHistoryItem(item) {
<span>☆</span>
</button>
</div>
<div class="history-item-text">${item.sourceText}</div>
<div class="history-item-translation">${item.translation}</div>
<div class="history-item-text">${escapeHtml(item.sourceText)}</div>
<div class="history-item-translation">${escapeHtml(item.translation)}</div>
`;

// 点击历史记录项，填充到翻译区域
Expand Down Expand Up @@ -1393,8 +1404,8 @@ function createFavoriteItem(item) {
<span>×</span>
</button>
</div>
<div class="favorite-item-text">${item.sourceText}</div>
<div class="favorite-item-translation">${item.translation}</div>
<div class="favorite-item-text">${escapeHtml(item.sourceText)}</div>
<div class="favorite-item-translation">${escapeHtml(item.translation)}</div>
`;

// 点击收藏项，填充到翻译区域
Expand Down