Enable preview task checkboxes - #320
Open
PathGao wants to merge 18 commits into
Open
Conversation
added 18 commits
July 31, 2026 11:07
This was referenced Jul 31, 2026
Contributor
Author
|
@alecdotdev This fixes the current preview task-checkbox regression from #148/#319. It is stacked after #318 and its predecessors; please review in that order. |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319
Comrak emits task checkboxes without the legacy class or data marker, leaving every preview task disabled. This change tags only renderer-confirmed task list items at the Rust boundary, then makes the preview activate only those items.
The toggle now uses the rendered source line rather than DOM checkbox order. It therefore updates the intended unordered, ordered, nested, quoted, and front-matter-bearing task while raw HTML controls and code-fence lookalikes remain inert.
This is stacked after #318 and its predecessors. Merge the predecessor chain first.
Validation
Post-Deploy Monitoring & Validation
No additional operational monitoring required: rendering stays local and no service, telemetry, or persistent schema changes. Owner: maintainer/reporter; validate by toggling Markdown tasks in preview after merge, including an ordered task and an inert raw HTML checkbox.
Fixes #148.