Avoid panics, allow more robust inputs and handle conversion errors - #47
Merged
Conversation
alerque
commented
Nov 13, 2025
alerque
commented
Nov 13, 2025
alerque
left a comment
alerque
left a comment
Owner
Author
There was a problem hiding this comment.
Hopefully I can cleanup the ergonomics here, some of this got messy.
alerque
force-pushed
the
typst-errors
branch
3 times, most recently
from
November 14, 2025 23:11
0be8c63 to
ad6dbb9
Compare
alerque
marked this pull request as ready for review
November 14, 2025 23:36
BREAKING CHANGE: The infalliable conversion functions are now mostly falliable. This allows them to be used more robustly when the inputs might not be know (e.g. the language identifier string hasn't been validated or input has invalid UTF-8 encoding). The catch is that it makes most function return a `Result<String>` instead of `String`.
alerque
force-pushed
the
typst-errors
branch
3 times, most recently
from
November 15, 2025 12:45
943ec67 to
048acda
Compare
…M 'unimplemented' traps
alerque
force-pushed
the
typst-errors
branch
from
November 15, 2025 13:54
048acda to
76f9205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.