Handle scale factors less than 1 in worker creation#72
Merged
Conversation
Ensure totalWarehouses defaults to 1 when scale factor truncates to 0. This fixes TestTPCCWorker failures where DB_SCALE_FACTOR=0.01 caused "The end index must be >= 1" assertion errors.
Alif-2001
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure totalWarehouses defaults to 1 when scale factor truncates to 0. This fixes TestTPCCWorker failures where DB_SCALE_FACTOR=0.01 caused "The end index must be >= 1" assertion errors.
Description of changes:
Fix TPC-C worker creation to handle scale factors less than 1 by ensuring at least 1 warehouse is used, preventing assertion failures in unit tests where scaleFactor=0.01 truncates to 0.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.