Skip to content

Handle scale factors less than 1 in worker creation #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HanzhouTang merged 1 commit into from
Feb 3, 2026
Merged

Handle scale factors less than 1 in worker creation #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/com/oltpbenchmark/benchmarks/tpcc/TPCCBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ private List<TPCCWorker> createTerminalsOldWay() throws SQLException {

// totalWarehouses is equal to numWarehouses in case of non-partitioned use case
int totalWarehouses = (int) workConf.getScaleFactor();
if (totalWarehouses <= 0) {
totalWarehouses = 1;
}

// [startWarehouseIndex, endWarehouseIndex] are both included.
// Use defaults if not configured: start=1, end=totalWarehouses, stride=1
Expand All @@ -109,8 +112,8 @@ private List<TPCCWorker> createTerminalsOldWay() throws SQLException {

assert startWarehouseIndex >= 1 : "The start index must be >= 1";
assert endWarehouseIndex >= 1 : "The end index must be >= 1";
assert endWarehouseIndex <= workConf.getScaleFactor()
: "The end index must be within the scale factor";
assert endWarehouseIndex <= totalWarehouses
: "The end index must be within the total warehouse number";
assert numWarehouses >= 1 : "At least need 1 warehouse to do benchmark";

// We distribute terminals evenly across the warehouses
Expand Down
Loading