chore(github): add pull request template with commit discipline checklist#1542
chore(github): add pull request template with commit discipline checklist#1542Gkrumbach07 wants to merge 16 commits into
Conversation
…list Implements the PR template called out in the ACP Constitution Follow-up TODOs (line 56) and required by RHOAIENG-55733. Covers commit discipline (Principle X), quality gates for all component types (Go, frontend, Python), documentation, and security — so contributors verify compliance without having to remember the rules from CLAUDE.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a pull request template to Changes
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
Summary
Adds
.github/PULL_REQUEST_TEMPLATE.mdto the Ambient Code Platform repository. Currently there is no PR template, so contributors must manually remember all conventions from CLAUDE.md and the ACP Constitution. This template auto-populates on every new PR and prompts contributors to verify compliance before merge.Implements RHOAIENG-55733 and fulfills the Follow-up TODO in
.specify/memory/constitution.mdline 56: "Update PR template to include commit discipline checklist".Changes
go vet, frontend →npm run build, Python runner →pytest), noanytypes, nopanic(), K8s OwnerReferences,GetK8sClientsForRequest()— all labeled with applicable component scopeSecurityContextrequirementsRelated Issues
RHOAIENG-55733 | Constitution TODO:
.specify/memory/constitution.md:56Type of Change
chore— tooling/config, no source code changedComponent(s)
.github/)Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit