Skip to content
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
95fa0f1
chore(github): add pull request template with commit discipline check…
Gkrumbach07 May 11, 2026
b1ec960
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
7904aff
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
5d03555
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
44a68ea
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
11d9a40
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
63edc23
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
a3bf780
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
6061187
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
d78d66f
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 11, 2026
99b061d
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 12, 2026
63c4185
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 12, 2026
802fe4d
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 12, 2026
728bf3a
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 12, 2026
8454e9c
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 12, 2026
6a20c89
Merge branch 'main' into feature/rhoaieng-55733-pr-template
mergify[bot] May 12, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
## Summary

<!-- What changed and why. Focus on the WHY — the code shows the WHAT. -->

## Related Issues

<!-- Jira: RHOAIENG-XXXXX | GitHub: #issue -->

## Type of Change

<!-- Check one -->
- [ ] `feat` — new feature
- [ ] `fix` — bug fix
- [ ] `refactor` — behavior-preserving restructure
- [ ] `test` — tests only
- [ ] `docs` — documentation only
- [ ] `chore` — tooling, deps, config

## Component(s)

<!-- Check all that apply -->
- [ ] backend
- [ ] frontend
- [ ] operator
- [ ] runner
- [ ] cli
- [ ] manifests
- [ ] docs

---

## Commit Discipline (Constitution Principle X)

- [ ] Each commit is atomic and independently revertable
- [ ] Conventional commit format used: `type(scope): description`
- [ ] Commit messages explain WHY, not WHAT
- [ ] No WIP commits (squashed before submission)
- [ ] Line counts within thresholds (bugfix ≤150, feat-small ≤300, feat-medium ≤500, refactor ≤400)
- [ ] PR total is under 600 lines — or justification below:

<!-- If PR exceeds 600 lines or a threshold, explain why it cannot be split: -->

## Quality

- [ ] Tests added or updated for all changes
- [ ] `make lint` passes
- [ ] `npm run build` passes (frontend)
- [ ] `go vet ./...` passes (Go components)
- [ ] `python -m pytest tests/` passes (runner)
- [ ] No `any` types in frontend TypeScript (frontend)
- [ ] No `panic()` in Go production code (Go components)
- [ ] OwnerReferences set on any new child Kubernetes resources (if applicable)
- [ ] User-facing ops use `GetK8sClientsForRequest()`, not the service account (if applicable)

## Documentation

- [ ] `CLAUDE.md` / `AGENTS.md` updated if conventions changed
- [ ] API changes documented
- [ ] Breaking changes noted in PR description

## Security

- [ ] No secrets, tokens, or API keys committed
- [ ] `SecurityContext` set on any new container specs (`runAsNonRoot`, drop `ALL` caps, `readOnlyRootFilesystem`)
Loading