Skip to content

🎨 Palette: Improve notification button focus accessibility#968

Open
anchapin wants to merge 2 commits intomainfrom
palette/improve-notification-button-focus-6516025862525388641
Open

🎨 Palette: Improve notification button focus accessibility#968
anchapin wants to merge 2 commits intomainfrom
palette/improve-notification-button-focus-6516025862525388641

Conversation

@anchapin
Copy link
Copy Markdown
Owner

@anchapin anchapin commented Apr 6, 2026

💡 What: Changed :focus to :focus-visible for notification buttons.
🎯 Why: To prevent unsightly focus outlines from appearing when users click buttons with a mouse/touch, while retaining them for keyboard navigation.
📸 Before/After: Outlines used to appear on mouse click; now they only appear on keyboard focus.
Accessibility: Ensures focus outlines are only shown when navigating via keyboard, reducing visual noise for mouse users and encouraging developers to keep focus styles intact rather than removing them entirely.


PR created automatically by Jules for task 6516025862525388641 started by @anchapin

Summary by Sourcery

Enhancements:

  • Adjust notification button focus styles to only appear on :focus-visible, aligning visual focus outlines with keyboard navigation rather than all pointer interactions.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings April 6, 2026 23:14
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces generic :focus styles on notification buttons with :focus-visible to preserve keyboard focus outlines while avoiding outlines on mouse/touch clicks.

File-Level Changes

Change Details Files
Restrict focus outlines on notification buttons to keyboard-visible focus using :focus-visible instead of :focus.
  • Updated focus selector for notification action button from :focus to :focus-visible while keeping outline styling unchanged
  • Updated focus selector for notification close button from :focus to :focus-visible while keeping outline styling unchanged
frontend/src/components/NotificationSystem/NotificationSystem.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Switching from :focus to :focus-visible drops focus styling in browsers that don’t support :focus-visible; consider adding a fallback (e.g., :focus, :focus-visible or a .focus-visible polyfill) to preserve accessibility across older browsers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Switching from `:focus` to `:focus-visible` drops focus styling in browsers that don’t support `:focus-visible`; consider adding a fallback (e.g., `:focus, :focus-visible` or a `.focus-visible` polyfill) to preserve accessibility across older browsers.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates notification button focus styling to use :focus-visible so focus outlines are intended to appear for keyboard navigation rather than mouse/touch interaction.

Changes:

  • Replace .notification-*-btn:focus selectors with .notification-*-btn:focus-visible in NotificationSystem component styles.

Comment on lines +284 to 288
.notification-action-btn:focus-visible,
.notification-close-btn:focus-visible {
outline: 2px solid #667eea;
outline-offset: 2px;
}
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching these rules from :focus to :focus-visible won’t actually prevent focus outlines on mouse click in this app, because the global stylesheet still applies button:focus { outline: ... } (see frontend/src/index.css:50-53). On mouse click, :focus-visible won’t match, so the global :focus outline will show instead. To achieve the intended behavior while preserving fallback, consider keeping a :focus style for non-supporting browsers and adding a :focus:not(:focus-visible) override to remove the outline for mouse/touch focus (or otherwise overriding the global button:focus for these button classes).

Copilot uses AI. Check for mistakes.
Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants