Skip to content

🎨 Palette: Improve notification button focus accessibility #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anchapin wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

🎨 Palette: Improve notification button focus accessibility #968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
010b6ca
🎨 Palette: Improve notification button focus accessibility
google-labs-jules[bot] Apr 6, 2026
7a76230
🎨 Palette: Improve notification button focus accessibility
google-labs-jules[bot] Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/NotificationSystem/NotificationSystem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,8 @@
}

/* Focus states for accessibility */
.notification-action-btn:focus,
.notification-close-btn:focus {
.notification-action-btn:focus-visible,
.notification-close-btn:focus-visible {
outline: 2px solid #667eea;
outline-offset: 2px;
}
Comment on lines +284 to 288
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching these rules from :focus to :focus-visible won’t actually prevent focus outlines on mouse click in this app, because the global stylesheet still applies button:focus { outline: ... } (see frontend/src/index.css:50-53). On mouse click, :focus-visible won’t match, so the global :focus outline will show instead. To achieve the intended behavior while preserving fallback, consider keeping a :focus style for non-supporting browsers and adding a :focus:not(:focus-visible) override to remove the outline for mouse/touch focus (or otherwise overriding the global button:focus for these button classes).

Copilot uses AI. Check for mistakes.
Expand Down
Loading