TRACE.m: collapse redundant is3D branch around convhull(Z) - #46
Merged
Conversation
convhull(P) accepts a single n-by-2 or n-by-3 points matrix directly, so branching between convhull(Z) and convhull(Z(:,1),Z(:,2)) produced identical results either way -- pure redundancy, not a correctness issue. Collapsed to one call. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111NcMAWwUUK3oGwfsb5yCp
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant dimensionality branching in TRACE.m when computing the overall instance-space convex hull measure, relying on MATLAB’s convhull ability to accept an n×2 or n×3 point matrix directly.
Changes:
- Collapsed the
is3Dbranch aroundconvhullinto a single call:[~, spaceArea] = convhull(Z). - Added an inline comment explaining why this call does not require dimensional dispatch, while other
area()/volume()uses still do.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convhull(P) accepts a single n-by-2 or n-by-3 points matrix directly, so branching between convhull(Z) and convhull(Z(:,1),Z(:,2)) produced identical results either way -- pure redundancy, not a correctness issue. Collapsed to one call.
Claude-Session: https://claude.ai/code/session_0111NcMAWwUUK3oGwfsb5yCp