Skip to content

TRACE.m: collapse redundant is3D branch around convhull(Z) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andremun merged 1 commit into from
Aug 5, 2026
Merged

TRACE.m: collapse redundant is3D branch around convhull(Z) #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions core/TRACE.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,10 @@
% -------------------------------------------------------------------------
% Space measure from convex hull of all instances (computed once).
% Passed to TRACEbuild3 so stopping criteria are relative to bounded space.
if is3D
[~, spaceArea] = convhull(Z);
else
[~, spaceArea] = convhull(Z(:,1), Z(:,2));
end
% convhull(Z) accepts Z directly as an n-by-2 or n-by-3 points matrix, so
% no is3D branch is needed here (unlike TRACEmetrics3's area()/volume()
% calls below, which really do need to dispatch on dimensionality).
[~, spaceArea] = convhull(Z);
if is3D; measureLabel = 'Volume'; else; measureLabel = 'Area'; end

% =========================================================================
Expand Down