fix(study-screen): streamline actions#20055
Open
BrayanDSO wants to merge 2 commits intoankidroid:mainfrom
Open
fix(study-screen): streamline actions#20055BrayanDSO wants to merge 2 commits intoankidroid:mainfrom
BrayanDSO wants to merge 2 commits intoankidroid:mainfrom
Conversation
6b51e4f to
6f5893a
Compare
6f5893a to
657b6cb
Compare
use `executeAction` as the single point of actions from the fragment that way, most uses of launchCatchingIO got removed, so actions won't run parallelly then use a mutex to make actions run in order inside `executeAction` fixes 19641
657b6cb to
7d04854
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Doing everything asynchronously and in parallel lead to some concurrency issues, like #19641
Fixes
Approach
use
executeActionas the single source of actions from the fragmentthat way, most uses of launchCatchingIO got removed, so actions won't run parallelly
then use a mutex to make actions run in order inside
executeActionAs
executeActionis supposed to be used only by the View, not in the ViewModel internal logic, it being "synchronic" is alright, I thinkHow Has This Been Tested?
Emulator 31 + an auto clicker
Screen_recording_20260108_154243.mp4
Checklist
Please, go through these checks before submitting the PR.