fix(Reviewer): Prevent double auto-advance trigger when answering manually#20289
Open
Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Open
fix(Reviewer): Prevent double auto-advance trigger when answering manually#20289Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Conversation
Contributor
|
Not a review but wanted to mention that the pr isn't following the standard template |
Contributor
Author
|
Thanks @ShaanNarendran for informing, I had changed it to standard template now. |
Member
|
I believe that the issue is fixed by #20055 (I couldn't reproduce it on that branch), which is a more definitive fix. |
Contributor
Author
5 tasks
Member
|
If it gets merged, it will automatically close this PR. No action needed for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes a race condition in the new study screen where manually answering a card while audio is playing causes the next card to auto-advance immediately.
Fixes
Approach
Temporarily disabled
autoAdvanceinReviewerViewModel.onShowAnswer()during the manual transition. This prevents the "audio stopped" event from the previous card from triggering the auto-advance timer for the new card.How Has This Been Tested?
Tested manually on an emulator with Auto Advance enabled (5s) and a deck with audio. Confirmed that answering quickly no longer causes double playback or immediate skipping.
Checklist
Please, go through these checks before submitting the PR.