Skip to content

Comments

ci: replace clang-format action with pip install#164

Merged
al1img merged 1 commit intoaosedge:feature_unificationfrom
MykolaSuperman:fix_ci_build
Feb 18, 2026
Merged

ci: replace clang-format action with pip install#164
al1img merged 1 commit intoaosedge:feature_unificationfrom
MykolaSuperman:fix_ci_build

Conversation

@MykolaSuperman
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feature_unification@41801a9). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             feature_unification     #164   +/-   ##
======================================================
  Coverage                       ?   82.23%           
======================================================
  Files                          ?      320           
  Lines                          ?    30350           
  Branches                       ?     3178           
======================================================
  Hits                           ?    24959           
  Misses                         ?     5391           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

uses: jidicula/clang-format-action@v4.11.0
with:
clang-format-version: "15"
run: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is inconsistency: cmake format does python -m pip install --upgrade pip where clang format doesn't. Probably we need to add step: "Install dependencies" where we will do:

python -m pip install --upgrade pip
pip install clang-format==15.0.7
pip install cmake_format

and then perform clang and cmake check?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@al1img al1img left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Copy link
Collaborator

@mykola-kobets-epam mykola-kobets-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
@sonarqubecloud
Copy link

@al1img al1img merged commit 24e10ef into aosedge:feature_unification Feb 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants