ci: replace clang-format action with pip install#164
ci: replace clang-format action with pip install#164al1img merged 1 commit intoaosedge:feature_unificationfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_unification #164 +/- ##
======================================================
Coverage ? 82.23%
======================================================
Files ? 320
Lines ? 30350
Branches ? 3178
======================================================
Hits ? 24959
Misses ? 5391
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| uses: jidicula/clang-format-action@v4.11.0 | ||
| with: | ||
| clang-format-version: "15" | ||
| run: | |
There was a problem hiding this comment.
There is inconsistency: cmake format does python -m pip install --upgrade pip where clang format doesn't. Probably we need to add step: "Install dependencies" where we will do:
python -m pip install --upgrade pip
pip install clang-format==15.0.7
pip install cmake_format
and then perform clang and cmake check?
3bd6e03 to
6866504
Compare
al1img
left a comment
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
6866504 to
94bff13
Compare
|



No description provided.