Skip to content

ci: replace clang-format action with pip install #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
al1img merged 1 commit into from
Feb 18, 2026
Merged

ci: replace clang-format action with pip install #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/check-format.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install clang-format==15.0.7 cmake_format

- name: Run clang-format style check
uses: jidicula/clang-format-action@v4.11.0
with:
clang-format-version: "15"
run: |
Copy link
Collaborator

@al1img al1img Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is inconsistency: cmake format does python -m pip install --upgrade pip where clang format doesn't. Probably we need to add step: "Install dependencies" where we will do:

python -m pip install --upgrade pip
pip install clang-format==15.0.7
pip install cmake_format

and then perform clang and cmake check?

Copy link
Author

@MykolaSuperman MykolaSuperman Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

find . -not -path '*/build/*' \( -name '*.cpp' -or -name '*.hpp' -or -name '*.c' -or -name '*.h' \) \
-exec clang-format --dry-run --Werror {} +

- name: Run cmake-format style check
run: |
python -m pip install --upgrade pip
pip install cmake_format
find . \( \( -not -path '*/build/*' \) -name '*.cmake' -or -name 'CMakeLists.txt' \) \
-exec cmake-format --check {} +;

Expand Down
Loading