Skip to content

Set batch size for selections buffer#9402

Closed
Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan:selection_batch_size
Closed

Set batch size for selections buffer#9402
Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan:selection_batch_size

Conversation

@Dandandan
Copy link
Contributor

Which issue does this PR close?

  • Closes #NNN.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 12, 2026
@Dandandan
Copy link
Contributor Author

run benchmark arrow_reader_clickbench

@alamb-ghbot
Copy link

🤖 ./gh_compare_arrow.sh gh_compare_arrow.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing selection_batch_size (68a9d13) to d6168e5 diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
BENCH_BRANCH_NAME=selection_batch_size
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

group                                             main                                   selection_batch_size
-----                                             ----                                   --------------------
arrow_reader_clickbench/async/Q1                  1.02      2.4±0.04ms        ? ?/sec    1.00      2.3±0.02ms        ? ?/sec
arrow_reader_clickbench/async/Q10                 1.00     11.8±0.39ms        ? ?/sec    1.00     11.8±0.28ms        ? ?/sec
arrow_reader_clickbench/async/Q11                 1.00     13.5±0.36ms        ? ?/sec    1.00     13.5±0.32ms        ? ?/sec
arrow_reader_clickbench/async/Q12                 1.00     23.1±0.21ms        ? ?/sec    1.01     23.4±0.23ms        ? ?/sec
arrow_reader_clickbench/async/Q13                 1.00     28.3±0.30ms        ? ?/sec    1.02     28.9±0.27ms        ? ?/sec
arrow_reader_clickbench/async/Q14                 1.00     25.2±0.38ms        ? ?/sec    1.02     25.8±0.32ms        ? ?/sec
arrow_reader_clickbench/async/Q19                 1.00      5.6±0.14ms        ? ?/sec    1.02      5.7±0.10ms        ? ?/sec
arrow_reader_clickbench/async/Q20                 1.10   124.7±11.62ms        ? ?/sec    1.00    113.2±0.56ms        ? ?/sec
arrow_reader_clickbench/async/Q21                 1.26    163.3±1.38ms        ? ?/sec    1.00    129.3±0.75ms        ? ?/sec
arrow_reader_clickbench/async/Q22                 1.00   244.0±27.76ms        ? ?/sec    1.17    285.5±2.42ms        ? ?/sec
arrow_reader_clickbench/async/Q23                 1.00    401.6±2.06ms        ? ?/sec    1.01    405.9±3.26ms        ? ?/sec
arrow_reader_clickbench/async/Q24                 1.00     31.2±0.37ms        ? ?/sec    1.02     31.9±0.44ms        ? ?/sec
arrow_reader_clickbench/async/Q27                 1.00     97.1±1.02ms        ? ?/sec    1.02     98.9±0.79ms        ? ?/sec
arrow_reader_clickbench/async/Q28                 1.00     95.5±1.06ms        ? ?/sec    1.02     97.0±1.08ms        ? ?/sec
arrow_reader_clickbench/async/Q30                 1.00     27.5±0.79ms        ? ?/sec    1.02     28.2±0.24ms        ? ?/sec
arrow_reader_clickbench/async/Q36                 1.00    115.4±0.73ms        ? ?/sec    1.01    116.8±0.60ms        ? ?/sec
arrow_reader_clickbench/async/Q37                 1.00     91.5±0.76ms        ? ?/sec    1.01     92.1±0.59ms        ? ?/sec
arrow_reader_clickbench/async/Q38                 1.00     34.9±0.33ms        ? ?/sec    1.02     35.5±0.23ms        ? ?/sec
arrow_reader_clickbench/async/Q39                 1.00     45.4±0.50ms        ? ?/sec    1.02     46.2±0.73ms        ? ?/sec
arrow_reader_clickbench/async/Q40                 1.00     39.9±0.75ms        ? ?/sec    1.02     40.6±0.39ms        ? ?/sec
arrow_reader_clickbench/async/Q41                 1.00     29.2±0.34ms        ? ?/sec    1.02     29.9±0.44ms        ? ?/sec
arrow_reader_clickbench/async/Q42                 1.00     11.1±0.19ms        ? ?/sec    1.02     11.2±0.32ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q1     1.00      2.3±0.02ms        ? ?/sec    1.02      2.3±0.04ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q10    1.00     10.9±0.37ms        ? ?/sec    1.04     11.4±0.36ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q11    1.00     12.4±0.34ms        ? ?/sec    1.04     12.9±0.32ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q12    1.00     22.0±0.31ms        ? ?/sec    1.03     22.6±0.27ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q13    1.00     26.8±0.28ms        ? ?/sec    1.02     27.5±0.33ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q14    1.00     24.4±0.21ms        ? ?/sec    1.03     25.1±0.31ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q19    1.00      5.1±0.09ms        ? ?/sec    1.04      5.3±0.13ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q20    1.00    108.0±0.63ms        ? ?/sec    1.01    109.2±0.64ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q21    1.00    123.2±0.62ms        ? ?/sec    1.01    124.6±0.89ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q22    1.00    226.7±1.62ms        ? ?/sec    1.01    229.5±1.70ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q23    1.03    364.6±2.00ms        ? ?/sec    1.00    353.1±1.71ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q24    1.00     30.0±0.40ms        ? ?/sec    1.02     30.5±0.36ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q27    1.00     93.3±0.59ms        ? ?/sec    1.01     94.0±0.56ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q28    1.00     91.3±0.45ms        ? ?/sec    1.01     92.0±0.62ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q30    1.00     26.4±0.23ms        ? ?/sec    1.03     27.2±0.23ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q36    1.00    110.7±0.68ms        ? ?/sec    1.01    111.8±0.69ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q37    1.00     87.9±0.47ms        ? ?/sec    1.01     88.9±0.52ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q38    1.00     32.0±0.44ms        ? ?/sec    1.01     32.4±0.21ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q39    1.00     40.5±0.39ms        ? ?/sec    1.02     41.1±0.40ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q40    1.00     38.3±0.39ms        ? ?/sec    1.02     38.8±0.83ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q41    1.00     27.8±0.30ms        ? ?/sec    1.01     28.1±0.41ms        ? ?/sec
arrow_reader_clickbench/async_object_store/Q42    1.00     10.4±0.13ms        ? ?/sec    1.01     10.6±0.20ms        ? ?/sec
arrow_reader_clickbench/sync/Q1                   1.00  1992.5±24.58µs        ? ?/sec    1.00  1994.9±12.88µs        ? ?/sec
arrow_reader_clickbench/sync/Q10                  1.00      7.7±0.18ms        ? ?/sec    1.00      7.7±0.09ms        ? ?/sec
arrow_reader_clickbench/sync/Q11                  1.00      9.1±0.17ms        ? ?/sec    1.00      9.2±0.11ms        ? ?/sec
arrow_reader_clickbench/sync/Q12                  1.01     29.6±1.40ms        ? ?/sec    1.00     29.2±0.29ms        ? ?/sec
arrow_reader_clickbench/sync/Q13                  1.00     34.6±0.73ms        ? ?/sec    1.08     37.2±3.86ms        ? ?/sec
arrow_reader_clickbench/sync/Q14                  1.23     39.3±0.89ms        ? ?/sec    1.00     31.8±0.32ms        ? ?/sec
arrow_reader_clickbench/sync/Q19                  1.00      4.2±0.10ms        ? ?/sec    1.03      4.3±0.13ms        ? ?/sec
arrow_reader_clickbench/sync/Q20                  1.00    175.5±0.90ms        ? ?/sec    1.00    174.7±1.07ms        ? ?/sec
arrow_reader_clickbench/sync/Q21                  1.00    226.5±4.98ms        ? ?/sec    1.03    232.7±1.59ms        ? ?/sec
arrow_reader_clickbench/sync/Q22                  1.00    473.5±3.47ms        ? ?/sec    1.00    475.8±3.99ms        ? ?/sec
arrow_reader_clickbench/sync/Q23                  1.00   440.5±17.13ms        ? ?/sec    1.00   440.1±16.17ms        ? ?/sec
arrow_reader_clickbench/sync/Q24                  1.00     40.2±0.41ms        ? ?/sec    1.04     42.0±0.51ms        ? ?/sec
arrow_reader_clickbench/sync/Q27                  1.00    150.9±0.99ms        ? ?/sec    1.02    153.6±1.06ms        ? ?/sec
arrow_reader_clickbench/sync/Q28                  1.00    145.3±1.01ms        ? ?/sec    1.01    146.9±1.17ms        ? ?/sec
arrow_reader_clickbench/sync/Q30                  1.00     28.3±0.30ms        ? ?/sec    1.02     28.7±0.57ms        ? ?/sec
arrow_reader_clickbench/sync/Q36                  1.00    150.5±1.15ms        ? ?/sec    1.01    151.4±1.37ms        ? ?/sec
arrow_reader_clickbench/sync/Q37                  1.00     84.8±0.56ms        ? ?/sec    1.00     84.9±0.84ms        ? ?/sec
arrow_reader_clickbench/sync/Q38                  1.00     28.1±0.16ms        ? ?/sec    1.01     28.3±0.22ms        ? ?/sec
arrow_reader_clickbench/sync/Q39                  1.00     33.6±0.38ms        ? ?/sec    1.00     33.7±0.48ms        ? ?/sec
arrow_reader_clickbench/sync/Q40                  1.00     26.4±0.32ms        ? ?/sec    1.01     26.6±0.36ms        ? ?/sec
arrow_reader_clickbench/sync/Q41                  1.00     27.8±0.33ms        ? ?/sec    1.01     28.0±0.41ms        ? ?/sec
arrow_reader_clickbench/sync/Q42                  1.00     11.8±0.11ms        ? ?/sec    1.01     12.0±0.11ms        ? ?/sec

@Dandandan Dandandan closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants