Skip to content

Set batch size for selections buffer #9402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dandandan wants to merge 1 commit into from
+4 −5
Closed

Set batch size for selections buffer #9402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions parquet/src/arrow/array_reader/cached_array_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ impl CachedArrayReader {
outer_position: 0,
inner_position: 0,
batch_size,
selections: BooleanBufferBuilder::new(0),
selections: BooleanBufferBuilder::new(batch_size),
role,
local_cache: HashMap::new(),
metrics,
Expand Down Expand Up @@ -226,7 +226,6 @@ impl ArrayReader for CachedArrayReader {
read += select_cnt;
self.metrics.increment_cache_reads(select_cnt);
self.outer_position += select_cnt;
self.selections.append_n(select_cnt, true);
} else {
// this is last batch and we have used all records from it
break;
Expand All @@ -245,14 +244,14 @@ impl ArrayReader for CachedArrayReader {
);
read += select_from_this_batch;
self.outer_position += select_from_this_batch;
self.selections.append_n(select_from_this_batch, true);
if read_from_inner < self.batch_size {
// this is last batch from inner reader
break;
}
}
}
}
self.selections.append_n(read, true);
Ok(read)
}

Expand All @@ -261,9 +260,9 @@ impl ArrayReader for CachedArrayReader {
while skipped < num_records {
let size = std::cmp::min(num_records - skipped, self.batch_size);
skipped += size;
self.selections.append_n(size, false);
self.outer_position += size;
}
self.selections.append_n(skipped, false);
Ok(num_records)
}

Expand Down Expand Up @@ -313,7 +312,7 @@ impl ArrayReader for CachedArrayReader {
selected_arrays.push(filtered);
}

self.selections = BooleanBufferBuilder::new(0);
self.selections = BooleanBufferBuilder::new(self.batch_size);

// Only remove batches from local buffer that are completely behind current position
// Keep the current batch and any future batches as they might still be needed
Expand Down
Loading