Skip to content

Support sharded coder for Prism runner cross-lang - #39623

Merged
jrmccluskey merged 1 commit into
apache:masterfrom
Abacn:sharded_coder
Aug 5, 2026
Merged

Support sharded coder for Prism runner cross-lang#39623
jrmccluskey merged 1 commit into
apache:masterfrom
Abacn:sharded_coder

Conversation

@Abacn

@Abacn Abacn commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here

Port from internal change (Gerrit#8549)

Needed for running BigQuery storage write schema transform on Prism Runner


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.14%. Comparing base (f2c622b) to head (758afcd).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
sdks/go/pkg/beam/runners/prism/internal/coders.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39623      +/-   ##
============================================
- Coverage     58.15%   58.14%   -0.02%     
  Complexity    13085    13085              
============================================
  Files          2521     2524       +3     
  Lines        264850   265435     +585     
  Branches      10788    10788              
============================================
+ Hits         154023   154324     +301     
- Misses       105051   105294     +243     
- Partials       5776     5817      +41     
Flag Coverage Δ
go 28.90% <80.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey jrmccluskey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey
jrmccluskey merged commit 1508227 into apache:master Aug 5, 2026
18 checks passed
@Abacn
Abacn deleted the sharded_coder branch August 5, 2026 13:51
@Abacn Abacn mentioned this pull request Aug 5, 2026
3 tasks
rwiggles pushed a commit to rwiggles/beam-rwiggles that referenced this pull request Aug 5, 2026
rwiggles pushed a commit to rwiggles/beam-rwiggles that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants