Skip to content

Support sharded coder for Prism runner cross-lang #39623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 1 commit into from
Aug 5, 2026
+27 −0
Merged

Support sharded coder for Prism runner cross-lang #39623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions sdks/go/pkg/beam/runners/prism/internal/coders.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,17 @@ func pullDecoderNoAlloc(c *pipepb.Coder, coders map[string]*pipepb.Coder) func(i
ed(r)
wd(r)
}
case urns.CoderShardedKey:
ccids := c.GetComponentCoderIds()
if len(ccids) != 1 {
panic(fmt.Sprintf("ShardedKey coder must have only 1 component: %s", prototext.Format(c)))
}
kd := pullDecoderNoAlloc(coders[ccids[0]], coders)
return func(r io.Reader) {
l, _ := coder.DecodeVarInt(r)
ioutilx.ReadN(r, int(l))
kd(r)
}
case urns.CoderRow:
panic(fmt.Sprintf("Runner forgot to LP this Row Coder. %v", prototext.Format(c)))
default:
Expand Down
16 changes: 16 additions & 0 deletions sdks/go/pkg/beam/runners/prism/internal/coders_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,22 @@ func Test_pullDecoder(t *testing.T) {
},
},
[]byte{3, 0},
}, {
"sharded_key",
&pipepb.Coder{
Spec: &pipepb.FunctionSpec{
Urn: urns.CoderShardedKey,
},
ComponentCoderIds: []string{"key"},
},
map[string]*pipepb.Coder{
"key": {
Spec: &pipepb.FunctionSpec{
Urn: urns.CoderVarInt,
},
},
},
[]byte{3, 1, 2, 3, 255, 3},
},
}
for _, test := range tests {
Expand Down
Loading