Improve AGENTS.md for PR review#24938
Merged
Merged
Conversation
apupier
marked this pull request as ready for review
July 20, 2026 10:25
gnodet
reviewed
Jul 20, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding review guidelines for AI agents, @apupier — this is a useful addition.
A few minor suggestions:
-
Double space typo on line 79:
"It must challenge"→"It must challenge"(extra space) -
Grammar:
"Wait that PR checks are green"reads a bit awkwardly in English — consider"Wait until PR checks are green"or"Wait for PR checks to be green" -
Capitalization/plural:
"For dependabot PR"→"For Dependabot PRs"(capital D since it's a proper noun, plural since it's general guidance) -
Clarity:
"check for deprecated/removal code"could be slightly clearer, e.g."check for deprecated APIs, removed features, or breaking changes in the changelog"
These are all minor polish — the content and intent are sound. The point about Dependabot PRs is well-taken: a rubber-stamp approval on a dependency bump that introduces breaking changes or deprecations doesn't add value.
Claude Code on behalf of gnodet — AI-generated review
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
apupier
force-pushed
the
improveAgentsMDForDependabotReview
branch
from
July 20, 2026 11:16
48c8c15 to
b63343a
Compare
gnodet
reviewed
Jul 20, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates, @apupier — looks much better! One small remaining typo:
- Line 79:
"check check for deprecated APIs"→"check for deprecated APIs"(duplicated word "check")
Claude Code on behalf of gnodet — AI-generated review
apupier
force-pushed
the
improveAgentsMDForDependabotReview
branch
from
July 20, 2026 11:28
b63343a to
7757440
Compare
gnodet
approved these changes
Jul 20, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
All feedback addressed — the "check check" typo is fixed, grammar and capitalization are clean. Good addition to the AI agent guidelines.
Claude Code on behalf of gnodet — AI-generated review
Contributor
|
ℹ️ CI did not run targeted module tests. 🔬 Scalpel shadow comparison — Scalpel: 647 tested, 29 compile-only — current: 0 all testedMaveniverse Scalpel detected 676 affected modules (current approach: 0).
|
Contributor
Author
|
PR error seems to be due to the fact too many tests are launched even though there is no need to test anything. I created #24947 |
Signed-off-by: Aurélien Pupier <apupier@ibm.com>
apupier
force-pushed
the
improveAgentsMDForDependabotReview
branch
from
July 20, 2026 13:53
7757440 to
9afe65d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.