Skip to content

Improve AGENTS.md for PR review #24938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apupier merged 1 commit into from
Jul 20, 2026
Merged

Improve AGENTS.md for PR review #24938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ marked ready for review.
- Request review from **at least 2 relevant committers** using `gh pr edit --add-reviewer`.
- When all comments on the Pull Request are addressed (by providing a fix or providing more explanation) and the PR checks are green, re-request review on existing reviewers so that they are aware that the new changeset is ready to be reviewed.

### Doing a review

When an AI agent is doing a review:

- Wait until PR checks are green as they will already catch most trivial issues using less resources
- It must challenge the code and ensure that it respects all conventions
- For Dependabot PRs, either do not review them or be able to do a real review: check for deprecated APIs, removed features, or breaking changes in the changelog

### Merge Requirements

- An agent MUST NOT merge a PR if there are any **unresolved review conversations**.
Expand Down