feat: remove warning parameter and suppression code from Adapter#19
Merged
Conversation
nomeguy
marked this pull request as ready for review
November 21, 2025 06:38
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix warning suppression in database adapter
Remove warning parameter and suppression code from Adapter
Nov 21, 2025
hsluoyz
added a commit
that referenced
this pull request
Nov 21, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
# [1.14.0](v1.13.0...v1.14.0) (2025-11-21) ### Features * remove warning parameter and suppression code from Adapter ([#19](#19)) ([456a940](456a940))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users cannot suppress the RuntimeWarning about using default CasbinRule table. The
warningparameter doesn't work as intended and the warning itself adds no value since users are explicitly choosing to use the default or custom table.Changes
warningparameter fromAdapter.__init__()db_class=NonewarningsimportExample
Before:
After:
The adapter continues to work with both default
CasbinRuleand custom database classes without emitting warnings.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.