Skip to content

feat: remove warning parameter and suppression code from Adapter #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nomeguy merged 2 commits into from
Nov 21, 2025
Merged

feat: remove warning parameter and suppression code from Adapter #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70ab993
Initial plan
Copilot Nov 21, 2025
b5cc03e
Remove warning parameter and warning code from Adapter
Copilot Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions casbin_async_sqlalchemy_adapter/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import warnings
from contextlib import asynccontextmanager
from typing import List, Optional

Expand Down Expand Up @@ -68,7 +67,6 @@ def __init__(
engine,
db_class=None,
filtered=False,
warning=True,
db_session: Optional[AsyncSession] = None,
):
if isinstance(engine, str):
Expand All @@ -78,12 +76,6 @@ def __init__(

if db_class is None:
db_class = CasbinRule
if warning:
warnings.warn(
"Using default CasbinRule table, please note the use of the 'Adapter().create_table()' method"
" to create the table, and ignore this warning if you are using a custom CasbinRule table.",
RuntimeWarning,
)
else:
for attr in (
"id",
Expand Down