ui: fix enable static nat only towards first nic and not on any other interface#3338
Conversation
anuragaw
left a comment
anuragaw
left a comment
There was a problem hiding this comment.
Very minor suggestion but code looks good. Since it's a UI Change, some snapshots would help.
| $.extend(data, { | ||
| networkid: network.id | ||
| }); | ||
| } |
There was a problem hiding this comment.
very minor suggestion- Alternate way of writing could be (just to make it smaller)-
var data = {
virtualmachineid: instance.id,
networkid: (args.context.networkid != undefined) ? args.context.networkid : network.id
}
There was a problem hiding this comment.
@anuragaw
Changed the code as you suggested, tested ok.
thanks for good suggestion.
…ny other interface
… not on any other interface
ustcweizhou
force-pushed
the
bugfix/vpc-enable-static-nat
branch
from
767356a to
3882758
Compare
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2779 |
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
Tested manually on local environment. LGTM
Thanks @ustcweizhou
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Purely UI changes, merged based on reviews. |
|
Trillian test result (tid-3604)
|
6 participants
Description
When enable static nat in a vpc on UI, it only lists the primary and secondary ips of first nic of a vm, no matter which vpc tier is selected.
The same issue happens when add a vm to load balancer.
Fixes: #3334
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?