[ISSUE #10819] Correct misleading CommitLog buffer comment - #10820
Merged
ShannonDing merged 2 commits intoAug 6, 2026
Conversation
fuyou001
marked this pull request as ready for review
August 6, 2026 02:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10820 +/- ##
=============================================
- Coverage 48.32% 48.25% -0.08%
+ Complexity 13516 13497 -19
=============================================
Files 1380 1380
Lines 101138 101138
Branches 13120 13120
=============================================
- Hits 48876 48800 -76
- Misses 46298 46353 +55
- Partials 5964 5985 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
approved these changes
Aug 6, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Trivial comment-only fix — the old comment incorrectly referred to "queue buffer" when the code writes to the CommitLog buffer. The corrected comment accurately describes the operation.
Automated review by github-manager-bot
ShannonDing
approved these changes
Aug 6, 2026
guyinyou
approved these changes
Aug 6, 2026
RockteMQ-AI
approved these changes
Aug 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Defensive fix with proper validation and test coverage. LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Correct the misleading comment before
byteBuffer.put(preEncodeBuffer)inDefaultAppendMessageCallback#doAppend(...).The destination buffer belongs to the CommitLog append path and may be backed by the mapped byte buffer, the transient write buffer, or the shared staging buffer used by
writeWithoutMmap. It is not a queue or ConsumeQueue buffer. The revised comment makes clear that this line appends an already encoded message to the CommitLog buffer.This is a documentation-only change with no runtime behavior, API, protocol, configuration, or persisted-format impact.
How Did You Test This Change?
git diff --checksuccessfully.