Skip to content

[ISSUE #10819] Correct misleading CommitLog buffer comment #10820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShannonDing merged 2 commits into from
Aug 6, 2026
Merged

[ISSUE #10819] Correct misleading CommitLog buffer comment #10820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fb1d49
[ISSUE #10819] Correct misleading CommitLog buffer comment
fuyou001 Aug 6, 2026
0724d74
[ISSUE #10819] Refine CommitLog comment wording
fuyou001 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion store/src/main/java/org/apache/rocketmq/store/CommitLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2092,7 +2092,7 @@ public AppendMessageResult doAppend(final long fileFromOffset, final ByteBuffer

final long beginTimeMills = CommitLog.this.defaultMessageStore.now();
CommitLog.this.getMessageStore().getPerfCounter().startTick("WRITE_MEMORY_TIME_MS");
// Write messages to the queue buffer
// Append the encoded message to the current CommitLog buffer
byteBuffer.put(preEncodeBuffer);
CommitLog.this.getMessageStore().getPerfCounter().endTick("WRITE_MEMORY_TIME_MS");
msgInner.setEncodedBuff(null);
Expand Down
Loading