fix: validate every Lite consumer subscription against its bound topic [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #10902
Open
waterWang wants to merge 2 commits into
Conversation
RockteMQ-AI
approved these changes
Aug 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fixes a validation bypass in ClientProcessor.validateLiteSubTopic where only the first subscription in the set was checked against the bound topic. The change correctly iterates over all subscriptions and adds a test case for the second-element mismatch scenario.
Clean, focused fix with proper test coverage. LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ClientProcessor.validateLiteSubTopicnow validates every subscription in the set against the group's bound topic, not just the first element.Why
ClientProcessor.validateLiteSubTopiccalledsubList.iterator().next().getTopic(), which only checks the first element of the subscription set. A Lite consumer group with a configuredliteBindTopiccould include a second subscription for a different topic without being rejected.How
forloop over all elementstestValidateLiteSubTopic_mismatchedSecondTopic_throwsExceptionto verify that a mismatching second subscription triggersILLEGAL_TOPICFixes #10895