Skip to content

fix: validate every Lite consumer subscription against its bound topic [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #10902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: validate every Lite consumer subscription against its bound topic [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] #10902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209ea10
fix: validate every Lite consumer subscription against its bound topic
waterWang Aug 11, 2026
b48fdfd
test: add coverage for validating every Lite subscription
waterWang Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions proxy/src/main/java/org/apache/rocketmq/proxy/processor/ClientProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,10 @@ protected void validateLiteSubTopic(ProxyContext ctx, String group, Set<Subscrip
if (CollectionUtils.isEmpty(subList)) {
return;
}
// check bindTopic for sub list
validateLiteBindTopic(ctx, group, subList.iterator().next().getTopic());
// check bindTopic for every subscription in the sub list
for (SubscriptionData subscriptionData : subList) {
validateLiteBindTopic(ctx, group, subscriptionData.getTopic());
}
}

protected void validateLiteBindTopic(ProxyContext ctx, String group, String bindTopic) {
Expand Down
21 changes: 21 additions & 0 deletions proxy/src/test/java/org/apache/rocketmq/proxy/processor/ClientProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,27 @@ public void testValidateLiteSubTopic_validSubList_noException() {
});
}

@Test
public void testValidateLiteSubTopic_mismatchedSecondTopic_throwsException() {
String group = "group";
String bindTopic = "topic1";
SubscriptionData matching = new SubscriptionData();
matching.setTopic(bindTopic);
SubscriptionData mismatching = new SubscriptionData();
mismatching.setTopic("topic2");
Set<SubscriptionData> subList = new HashSet<>();
subList.add(matching);
subList.add(mismatching);

when(groupConfig.getLiteBindTopic()).thenReturn(bindTopic);
when(messagingProcessor.getSubscriptionGroupConfig(ctx, group)).thenReturn(groupConfig);

GrpcProxyException exception = assertThrows(GrpcProxyException.class, () -> {
clientProcessor.validateLiteSubTopic(ctx, group, subList);
});
assertTrue(exception.getMessage().contains("expected to bind topic"));
}

@Test
public void testValidateLiteBindTopic_matchingTopics_noException() {
String group = "group";
Expand Down