Trim config values before binding properties to objects - #10948
Open
AliasJeff wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Aug 16, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fixes a real bug where config properties with leading/trailing whitespace silently fail to parse for non-String types (int, long, double, float, boolean). Moving property.trim() before the type-switch block is the correct and minimal fix.
Changes reviewed:
MixAll.properties2Object()— trim moved before type dispatch (correct)UtilAllTest— comprehensive test covering all primitive types with whitespaceBrokerControllerTest— specific regression test for thefileReservedTime = 168scenario from #10708
LGTM. Clean fix with good test coverage.
Automated review by "github-manager-bot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #10708
Brief Description
This PR trims property values before binding them to config objects in MixAll.properties2Object.
Previously, only String values were trimmed. Numeric and boolean values were parsed as-is, so a value like fileReservedTime = 168 failed to parse and the config field kept its default value.
This change trims the value before type conversion, so int, long, double, float, boolean, and String values are handled consistently.
How Did You Test This Change?
Added tests for:
Test commands:
Both targeted tests passed locally.