Skip to content

[ISSUE #8920] Make TLS certificate watch interval configurable - #9513

Merged
lollipopjin merged 1 commit into
apache:developfrom
EnableAsync:feat/cert-update-online
Jul 2, 2025
Merged

[ISSUE #8920] Make TLS certificate watch interval configurable#9513
lollipopjin merged 1 commit into
apache:developfrom
EnableAsync:feat/cert-update-online

Conversation

@EnableAsync

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

This PR makes the watch interval for TLS certificate and key files configurable in the Proxy module.

Previously, the interval was hardcoded to 1 hour, which is not flexible for different production environments. A new configuration property tlsCertWatchIntervalMs has been introduced in ProxyConfig with a default value of 1 hour (60 * 60 * 1000ms), which is more reasonable for most use cases.

Fixes #8920

Brief Description

How Did You Test This Change?

@codecov-commenter

codecov-commenter commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.96%. Comparing base (be67d61) to head (85fffff).
⚠️ Report is 223 commits behind head on develop.

Files with missing lines Patch % Lines
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 50.00% 2 Missing ⚠️
...etmq/proxy/service/cert/TlsCertificateManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9513   +/-   ##
==========================================
  Coverage      47.95%   47.96%           
- Complexity     11989    11992    +3     
==========================================
  Files           1309     1309           
  Lines          92360    92365    +5     
  Branches       11819    11819           
==========================================
+ Hits           44290    44300   +10     
  Misses         42559    42559           
+ Partials        5511     5506    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lollipopjin lollipopjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnableAsync
EnableAsync force-pushed the feat/cert-update-online branch from 2a77493 to 92c8b87 Compare July 1, 2025 09:41
Signed-off-by: Async <raisinata@foxmail.com>
@EnableAsync
EnableAsync force-pushed the feat/cert-update-online branch from 92c8b87 to 85fffff Compare July 1, 2025 11:39

@lollipopjin lollipopjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin
lollipopjin merged commit c3c4101 into apache:develop Jul 2, 2025
10 of 16 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
…ache#9513)

refactor(proxy): Make TLS certificate watch interval configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Refactor SSL context loading process to support multiple protocols dynamic loading.

3 participants