[ISSUE #8920] Make TLS certificate watch interval configurable - #9513
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9513 +/- ##
==========================================
Coverage 47.95% 47.96%
- Complexity 11989 11992 +3
==========================================
Files 1309 1309
Lines 92360 92365 +5
Branches 11819 11819
==========================================
+ Hits 44290 44300 +10
Misses 42559 42559
+ Partials 5511 5506 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EnableAsync
force-pushed
the
feat/cert-update-online
branch
from
July 1, 2025 09:41
2a77493 to
92c8b87
Compare
Signed-off-by: Async <raisinata@foxmail.com>
EnableAsync
force-pushed
the
feat/cert-update-online
branch
from
July 1, 2025 11:39
92c8b87 to
85fffff
Compare
hechen0
pushed a commit
to hechen0/rocketmq
that referenced
this pull request
Aug 18, 2025
…ache#9513) refactor(proxy): Make TLS certificate watch interval configurable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
This PR makes the watch interval for TLS certificate and key files configurable in the Proxy module.
Previously, the interval was hardcoded to 1 hour, which is not flexible for different production environments. A new configuration property tlsCertWatchIntervalMs has been introduced in ProxyConfig with a default value of 1 hour (60 * 60 * 1000ms), which is more reasonable for most use cases.
Fixes #8920
Brief Description
How Did You Test This Change?