Skip to content

[ISSUE #8920] Make TLS certificate watch interval configurable #9513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lollipopjin merged 1 commit into from
Jul 2, 2025
Merged

[ISSUE #8920] Make TLS certificate watch interval configurable #9513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public class ProxyConfig implements ConfigFile {
private boolean tlsTestModeEnable = true;
private String tlsKeyPath = ConfigurationManager.getProxyHome() + "/conf/tls/rocketmq.key";
private String tlsCertPath = ConfigurationManager.getProxyHome() + "/conf/tls/rocketmq.crt";
private int tlsCertWatchIntervalMs = 60 * 60 * 1000; // 1 hour
/**
* gRPC
*/
Expand Down Expand Up @@ -325,6 +326,14 @@ public void parseDelayLevel() {
}
}

public int getTlsCertWatchIntervalMs() {
return tlsCertWatchIntervalMs;
}

public void setTlsCertWatchIntervalMs(int tlsCertWatchIntervalMs) {
this.tlsCertWatchIntervalMs = tlsCertWatchIntervalMs;
}

public String getRocketMQClusterName() {
return rocketMQClusterName;
}
Expand Down
5 changes: 3 additions & 2 deletions proxy/src/main/java/org/apache/rocketmq/proxy/service/cert/TlsCertificateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* limitations under the License.
*/
package org.apache.rocketmq.proxy.service.cert;

import org.apache.rocketmq.common.constant.LoggerName;
import org.apache.rocketmq.common.utils.StartAndShutdown;
import org.apache.rocketmq.logging.org.slf4j.Logger;
Expand All @@ -39,7 +40,7 @@ public TlsCertificateManager() {
ConfigurationManager.getProxyConfig().getTlsKeyPath()
},
new CertKeyFileWatchListener(),
60 * 60 * 1000 /* 1 hour */
ConfigurationManager.getProxyConfig().getTlsCertWatchIntervalMs()
);
} catch (Exception e) {
log.error("Failed to initialize TLS certificate watch service", e);
Expand Down Expand Up @@ -107,7 +108,7 @@ private void notifyContextReload() {
for (TlsContextReloadListener listener : reloadListeners) {
try {
listener.onTlsContextReload();
} catch (Exception e) {
} catch (Throwable e) {
log.error("Failed to notify TLS context reload to listener: " + listener, e);
}
}
Expand Down
Loading