Skip to content

[ISSUE #9544] Must correct file size when init the file segment - #9545

Merged
lizhimins merged 1 commit into
apache:developfrom
lizhimins:zhimin/correct-file-size
Jul 14, 2025
Merged

[ISSUE #9544] Must correct file size when init the file segment#9545
lizhimins merged 1 commit into
apache:developfrom
lizhimins:zhimin/correct-file-size

Conversation

@lizhimins

Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9544

Brief Description

How Did You Test This Change?

@codecov-commenter

codecov-commenter commented Jul 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.03%. Comparing base (76cee72) to head (197b314).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ache/rocketmq/tieredstore/file/FlatAppendFile.java 42.85% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9545   +/-   ##
==========================================
  Coverage      48.02%   48.03%           
- Complexity     12039    12046    +7     
==========================================
  Files           1313     1313           
  Lines          92762    92771    +9     
  Branches       11862    11862           
==========================================
+ Hits           44547    44559   +12     
- Misses         42695    42698    +3     
+ Partials        5520     5514    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lollipopjin lollipopjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins
lizhimins merged commit d8fa28c into apache:develop Jul 14, 2025
10 of 13 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Must correct file size when init the file segment

3 participants