Skip to content

[ISSUE #9544] Must correct file size when init the file segment #9545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhimins merged 1 commit into from
Jul 14, 2025
Merged

[ISSUE #9544] Must correct file size when init the file segment #9545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatAppendFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.List;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import java.util.stream.Collectors;
import org.apache.rocketmq.tieredstore.common.AppendResult;
Expand Down Expand Up @@ -70,16 +71,40 @@ public void recover() {
this.fileSegmentTable.addAll(fileSegmentList.stream().sorted().collect(Collectors.toList()));
}

/**
* Retrieves the correct file size when initializing the file segment.
*
* @param fileSegment The file segment to get the size for.
* @return The correct length if the remote file exists,
* 0 if it does not exist,
* or -1 if the RPC fails.
* @see <a href="https://github.com/apache/rocketmq/issues/9544">Related GitHub Issue</a>
*/
public long getFileCorrectSize(FileSegment fileSegment) {
while (true) {
long fileSize = fileSegment.getSize();
if (fileSize != GET_FILE_SIZE_ERROR) {
log.debug("FlatAppendFile get file correct size, filePath={} fileType={}, fileSize={}",
fileSegment.getPath(), fileSegment.getFileType(), fileSize);
return fileSize;
} else {
log.warn("FlatAppendFile get file correct size error, filePath={}, fileType={}",
fileSegment.getPath(), fileSegment.getFileType());
try {
TimeUnit.MILLISECONDS.sleep(50);
} catch (InterruptedException e) {
log.warn("FlatAppendFile get file correct size interrupted", e);
}
}
}
}

public void recoverFileSize() {
if (fileSegmentTable.isEmpty() || FileSegmentType.INDEX.equals(fileType)) {
return;
}
FileSegment fileSegment = fileSegmentTable.get(fileSegmentTable.size() - 1);
long fileSize = fileSegment.getSize();
if (fileSize == GET_FILE_SIZE_ERROR) {
log.warn("FlatAppendFile get last file size error, filePath: {}", this.filePath);
return;
}
long fileSize = this.getFileCorrectSize(fileSegment);
if (fileSegment.getCommitPosition() != fileSize) {
fileSegment.initPosition(fileSize);
flushFileSegmentMeta(fileSegment);
Expand All @@ -90,7 +115,7 @@ public void recoverFileSize() {
public void initOffset(long offset) {
if (this.fileSegmentTable.isEmpty()) {
FileSegment fileSegment = fileSegmentFactory.createSegment(fileType, filePath, offset);
fileSegment.initPosition(fileSegment.getSize());
fileSegment.initPosition(this.getFileCorrectSize(fileSegment));
this.flushFileSegmentMeta(fileSegment);
this.fileSegmentTable.add(fileSegment);
}
Expand Down
Loading