Open
Conversation
- Closes apple#1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
jglogan
commented
Mar 13, 2026
| initialBackoff: TimeInterval(1), | ||
| maximumBackoff: TimeInterval(10) | ||
|
|
||
| let channel = try ClientBootstrap(group: group) |
Contributor
Author
There was a problem hiding this comment.
Replace grpc-swift client setup with the grpc-swift-2 approach, initializing our buffering handler in place to deal with the server sending the SETTINGS frame before the pipeline can handle it.
jglogan
commented
Mar 13, 2026
| try channel.pipeline.syncOperations.addHandler(HTTP2ConnectBufferingHandler()) | ||
| }) | ||
| } | ||
| .withConnectedSocket(socket.fileDescriptor) |
Contributor
Author
There was a problem hiding this comment.
the fd for the vsock between us and the buildkit container
jglogan
commented
Mar 13, 2026
| } | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We've already reviewed this approach in apple/containerization#578
jglogan
commented
Mar 13, 2026
| switch logLevel { | ||
| case .debug, .trace: | ||
| let timestamp = ISO8601DateFormatter().string(from: Date()) | ||
| let timestamp = isoTimestamp() |
Contributor
Author
There was a problem hiding this comment.
Let's not construct a non-Sendable date formatter every log message.
JaewonHur
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
The new library is more actively maintained
Testing