double vertical resolution with half blocks#4
Open
JustinH11235 wants to merge 2 commits intoarraypad:masterfrom
Open
double vertical resolution with half blocks#4JustinH11235 wants to merge 2 commits intoarraypad:masterfrom
JustinH11235 wants to merge 2 commits intoarraypad:masterfrom
Conversation
dmadisetti
reviewed
Jul 3, 2022
dmadisetti
reviewed
Jul 24, 2022
| } | ||
| ColorMode::Rgb => { | ||
| if false { | ||
| if y & 1 == 0 { |
There was a problem hiding this comment.
I think y % 2 is a bit better. Also, a little concerned that this probably breaks Luma ColorMode?
Owner
There was a problem hiding this comment.
I'm happy with y & 1. @dmadisetti what's the concern with Luma ColorModel here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses upper half blocks (chars that take up half of the terminal cell) combined with a colored background color to have 2 pixels per terminal cell.