fix: correct test expectation for first aggregate with include_nil?#683
Merged
zachdaniel merged 1 commit intomainfrom Feb 4, 2026
Merged
fix: correct test expectation for first aggregate with include_nil?#683zachdaniel merged 1 commit intomainfrom
first aggregate with include_nil?#683zachdaniel merged 1 commit intomainfrom
Conversation
The test was asserting buggy behavior. With `sort(title: :asc_nils_first)` and `include_nil?: true`, the `first` aggregate should return `nil` when the first sorted record has a nil value, not skip to the next non-nil value.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was asserting buggy behavior. With
sort(title: :asc_nils_first)andinclude_nil?: true, thefirstaggregate should returnnilwhen the first sorted record has a nil value, not skip to the next non-nil value.The fix to make this updated test actually pass is in ash_sql here - ash-project/ash_sql#210
Contributor checklist
Leave anything that you believe does not apply unchecked.