fix: use array_agg instead of any_value when include_nil? is true
#210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On PostgreSQL 16+, `any_value()` was used for `first` aggregates as an optimization. However, `any_value()` by PostgreSQL design returns "an arbitrary value from the non-null input values" - it inherently skips NULLs. This broke `include_nil?: true` for `first` aggregates. When `include_nil?` is true, we now always use `array_agg` with `[1]` indexing, since only `array_agg` can include NULL values in the result. Reference: https://www.postgresql.org/docs/16/functions-aggregate.html
Merged
7 tasks
zachdaniel
approved these changes
Feb 4, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PostgreSQL 16+,
any_value()was used forfirstaggregates as an optimization. However,any_value()by PostgreSQL design returns "an arbitrary value from the non-null input values" - it inherently skips NULLs. This brokeinclude_nil?: trueforfirstaggregates.When
include_nil?is true, we now always usearray_aggwith[1]indexing, since onlyarray_aggcan include NULL values in the result.Reference: https://www.postgresql.org/docs/16/functions-aggregate.html
This makes the newly-failing test in ash-project/ash_postgres#683 pass.
Contributor checklist
Leave anything that you believe does not apply unchecked.