Fix: remove upstream_failed from TERMINAL_DAG_RUN_STATES#166
Merged
Conversation
upstream_failed is a task instance state, not a DAG run state. DAG runs only reach success or failed as terminal states. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kaxil
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream_failedfromTERMINAL_DAG_RUN_STATESinconstants.pytest_utils.pyWhy
upstream_failedis a task instance state, not a DAG run state. DAG runs only ever reachsuccessorfailedas terminal states. Includingupstream_failedinTERMINAL_DAG_RUN_STATESwas incorrect — a DAG run would never have that state, so polling logic would never stop on it anyway, but it was misleading and wrong.upstream_failedremains correctly inFAILED_TASK_STATES, where it belongs.