Skip to content

Fix: remove upstream_failed from TERMINAL_DAG_RUN_STATES #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Mar 24, 2026
Merged

Fix: remove upstream_failed from TERMINAL_DAG_RUN_STATES #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion astro-airflow-mcp/src/astro_airflow_mcp/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Shared constants for CLI and MCP server."""

# Terminal states for DAG runs (polling stops when reached)
TERMINAL_DAG_RUN_STATES = {"success", "failed", "upstream_failed"}
TERMINAL_DAG_RUN_STATES = {"success", "failed"}

# Task states considered as failures
FAILED_TASK_STATES = {"failed", "upstream_failed"}
Expand Down
2 changes: 1 addition & 1 deletion astro-airflow-mcp/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class TestConstants:

def test_terminal_dag_run_states(self):
"""Test terminal DAG run states are defined correctly."""
assert {"success", "failed", "upstream_failed"} == TERMINAL_DAG_RUN_STATES
assert {"success", "failed"} == TERMINAL_DAG_RUN_STATES

def test_failed_task_states(self):
"""Test failed task states are defined correctly."""
Expand Down
Loading