chore(governance): record Classic Pages settings - #71
Merged
Conversation
zoeyrose
marked this pull request as ready for review
August 14, 2026 17:40
Member
Author
|
Final whole-diff review is complete at
This PR is ready to merge. It does not mutate the live Pages source; activation remains the documented post-merge owner operation after the consuming Classic PR lands. |
zoeyrose
added a commit
to atrinik/classic
that referenced
this pull request
Aug 14, 2026
## Summary - repair the trusted daily benchmark to run the exact complete `client-benchmark` matrix and preserve explicit early-failure diagnostics - replace generated-branch persistence with a bounded, digest-validated, no-JavaScript Pages site and versioned JSON checkpoint - retain detailed points separately from compact trend/state, enforce 90-point, cohort, file, and byte bounds, and physically prune aged files - validate the last successful Pages deployment or the recorded final generated-data commit before deterministic projection - isolate benchmark/projection, Pages deployment, and alert permissions; remove every report-path `contents: write` - reconcile regression issues idempotently only after a successful deployment - document interpretation, bootstrap, rerun/backfill, recovery, provider outage, and post-merge activation Supports #311. The issue remains the manual post-merge close path because its 30-consecutive-point rollout criterion cannot be satisfied by merging code. Governance companion: atrinik/github-settings#71 ## Coordinates - Base: `main` at `1f98d430a03e6d9fbf6f27f4ca1356542d905d08` - Head: `feat/benchmark-pages` at `aaf359d3aae4c41f2c5d89395b9f4410b1b7a62e` - Worktree: `/workspaces/atrinik/workspace/worktrees/classic/issue-311-benchmark-pages` - Commits: `2279042 feat(ci): publish branchless performance reports`; `aaf359d fix(ci): harden performance checkpoint recovery` - Frozen bootstrap commit: `bab40ecefefa5b6052d42eab6390c504b9482e81` ## Validation - `python3 -m unittest discover -s tools/tests -p 'test_*.py'` — 233 passed - `python3 -m compileall -q tools/ci tools/tests` - `python3 tools/verify_import_history.py` — five imported histories verified - `actionlint .github/workflows/*.yml` - exact frozen-data bootstrap rehearsal — generation 1 retained historical run `31755454661` plus a fresh compatible projection - `git diff --check 1f98d43..HEAD` Two complete whole-diff review rounds finished with zero known actionable findings. The focused tests cover byte-stable reconstruction, split projection, manifest/detailed-point/report binding, higher-attempt replacement, watermarks and global pruning, HTML escaping/no JavaScript, tamper and stale-file failure, synthetic alert regression/recovery, partial-operation retry deduplication, ambiguous issue ownership, exact matrix/trust restrictions, pinned Actions, and job permission isolation. ## Verification and activation Gameplay runtime is not applicable: this change owns CI evidence projection and static publication, not client/server behavior. Before merge, use the validation commands above. After this PR and the governance companion merge, an organization owner follows the governance runbook to switch the exact Classic Pages site to the Actions source. Then dispatch `Daily Classic client performance` from `main` once with `checkpoint_source=final-benchmark-data`, verify the raw/checkpoint artifacts and deployed endpoints, and use `checkpoint_source=pages` for every later manual run. Do not delete or update `benchmark-data`; its final commit remains rollback evidence. The prior site remains live on benchmark, predecessor, projection, validation, or deployment failure. Human rollout evidence—manual bootstrap, scheduled continuity, synthetic live alert transition, and at least 30 compatible daily points—remains tracked on #311 after merge.
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atrinik/classicPages site and exactgithub-pagesenvironment as manual desired statemain-root source while the immutable deployment marker is absent from the default branchCloses #70.
Related to atrinik/classic#311.
Consuming workflow: atrinik/classic#317
Coordinates
mainat4e24785c734d819af47422c0747cbe35c7251c40chore/classic-pages-governanceat2a358367540be20a1db79efffe1851c1ee9651ba/workspaces/atrinik/workspace/worktrees/github-settings/issue-70-classic-pagesa208b71 chore(governance): record Classic Pages settings;2a35836 fix(governance): constrain empty environment secretsValidation
bin/validatetests/validate-manual-environments.shtests/verify-manual-settings.shbash -n bin/validate bin/verify-manual-settings tests/validate-manual-environments.sh tests/verify-manual-settings.shshellcheck bin/validate bin/verify-manual-settings tests/validate-manual-environments.sh tests/verify-manual-settings.shbin/verify-manual-settingsagainst live GitHub: expectedPENDINGlegacy Pages source; both environments and other manual settings convergedbin/publishplan: no unexpected deletion or policy relaxation; manual settings remain explicitly non-appliedgit diff --check 4e24785c734d819af47422c0747cbe35c7251c40..HEADA fresh complete post-fix review found zero known actionable findings. The schema regression suite confirms that only the exact
github-pagesenvironment may declare an empty secret set.Activation boundary
This PR does not mutate live Pages. It may merge before the consuming Classic PR. After both are merged, an organization owner must follow the documented runbook to switch only
atrinik/classicPages to the Actions source, run the live verifier, and bootstrap the report from the recorded final generated-data commit.