feat(ci): publish branchless performance reports - #317
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
zoeyrose
marked this pull request as ready for review
August 14, 2026 17:40
Member
Author
|
Final whole-diff review is complete at
The Codecov informational comment was reviewed. Its required This PR is ready to merge. Issue #311 intentionally remains open for its post-merge activation and 30-compatible-point rollout evidence. |
zoeyrose
added a commit
to atrinik/github-settings
that referenced
this pull request
Aug 14, 2026
## Summary - record the provider-managed `atrinik/classic` Pages site and exact `github-pages` environment as manual desired state - validate repository/site/source/workflow-marker/environment identity and fail closed on drift - permit only the exact legacy `main`-root source while the immutable deployment marker is absent from the default branch - require the Actions source as soon as the reviewed Classic workflow marker lands - document the read-only preflight, post-merge source switch, bootstrap, verification, and rollback boundary Closes #70. Related to atrinik/classic#311. Consuming workflow: atrinik/classic#317 ## Coordinates - Base: `main` at `4e24785c734d819af47422c0747cbe35c7251c40` - Head: `chore/classic-pages-governance` at `2a358367540be20a1db79efffe1851c1ee9651ba` - Worktree: `/workspaces/atrinik/workspace/worktrees/github-settings/issue-70-classic-pages` - Commits: `a208b71 chore(governance): record Classic Pages settings`; `2a35836 fix(governance): constrain empty environment secrets` ## Validation - `bin/validate` - `tests/validate-manual-environments.sh` - `tests/verify-manual-settings.sh` - `bash -n bin/validate bin/verify-manual-settings tests/validate-manual-environments.sh tests/verify-manual-settings.sh` - `shellcheck bin/validate bin/verify-manual-settings tests/validate-manual-environments.sh tests/verify-manual-settings.sh` - `bin/verify-manual-settings` against live GitHub: expected `PENDING` legacy Pages source; both environments and other manual settings converged - `bin/publish` plan: no unexpected deletion or policy relaxation; manual settings remain explicitly non-applied - `git diff --check 4e24785..HEAD` A fresh complete post-fix review found zero known actionable findings. The schema regression suite confirms that only the exact `github-pages` environment may declare an empty secret set. ## Activation boundary This PR does not mutate live Pages. It may merge before the consuming Classic PR. After both are merged, an organization owner must follow the documented runbook to switch only `atrinik/classic` Pages to the Actions source, run the live verifier, and bootstrap the report from the recorded final generated-data commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client-benchmarkmatrix and preserve explicit early-failure diagnosticscontents: writeSupports #311. The issue remains the manual post-merge close path because its 30-consecutive-point rollout criterion cannot be satisfied by merging code.
Governance companion: atrinik/github-settings#71
Coordinates
mainat1f98d430a03e6d9fbf6f27f4ca1356542d905d08feat/benchmark-pagesataaf359d3aae4c41f2c5d89395b9f4410b1b7a62e/workspaces/atrinik/workspace/worktrees/classic/issue-311-benchmark-pages2279042 feat(ci): publish branchless performance reports;aaf359d fix(ci): harden performance checkpoint recoverybab40ecefefa5b6052d42eab6390c504b9482e81Validation
python3 -m unittest discover -s tools/tests -p 'test_*.py'— 233 passedpython3 -m compileall -q tools/ci tools/testspython3 tools/verify_import_history.py— five imported histories verifiedactionlint .github/workflows/*.yml31755454661plus a fresh compatible projectiongit diff --check 1f98d430a03e6d9fbf6f27f4ca1356542d905d08..HEADTwo complete whole-diff review rounds finished with zero known actionable findings. The focused tests cover byte-stable reconstruction, split projection, manifest/detailed-point/report binding, higher-attempt replacement, watermarks and global pruning, HTML escaping/no JavaScript, tamper and stale-file failure, synthetic alert regression/recovery, partial-operation retry deduplication, ambiguous issue ownership, exact matrix/trust restrictions, pinned Actions, and job permission isolation.
Verification and activation
Gameplay runtime is not applicable: this change owns CI evidence projection and static publication, not client/server behavior. Before merge, use the validation commands above.
After this PR and the governance companion merge, an organization owner follows the governance runbook to switch the exact Classic Pages site to the Actions source. Then dispatch
Daily Classic client performancefrommainonce withcheckpoint_source=final-benchmark-data, verify the raw/checkpoint artifacts and deployed endpoints, and usecheckpoint_source=pagesfor every later manual run. Do not delete or updatebenchmark-data; its final commit remains rollback evidence.The prior site remains live on benchmark, predecessor, projection, validation, or deployment failure. Human rollout evidence—manual bootstrap, scheduled continuity, synthetic live alert transition, and at least 30 compatible daily points—remains tracked on #311 after merge.