fix: node info accepts --rpc-url as fallback for --ip#26
Open
devrel-ditto wants to merge 1 commit intoava-labs:mainfrom
Open
fix: node info accepts --rpc-url as fallback for --ip#26devrel-ditto wants to merge 1 commit intoava-labs:mainfrom
devrel-ditto wants to merge 1 commit intoava-labs:mainfrom
Conversation
The node info command required --ip while every other command uses the global --rpc-url flag. Now node info checks --ip first, then falls back to --rpc-url, making it consistent with the rest of the CLI. --ip is preserved for backward compatibility. Fixes ava-labs#24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #24 —
node infonow accepts the global--rpc-urlflag as a fallback when--ipis not provided.Problem
Every command uses
--rpc-urlfor custom endpoints, butnode infoonly accepted--ip:Fix
--ipfirst (backward compatible)--rpc-urlif--ipnot provided--ip or --rpc-url is requiredThe underlying
GetNodeInfoWithInsecureHTTPalready accepts full URIs, so no changes needed in the node package.Testing