Skip to content

fix: node info accepts --rpc-url as fallback for --ip #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devrel-ditto wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Open

fix: node info accepts --rpc-url as fallback for --ip #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions cmd/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,23 @@ var nodeIP string
var nodeInfoCmd = &cobra.Command{
Use: "info",
Short: "Get node information",
Long: `Get node ID and BLS public key from an avalanchego node.`,
Long: `Get node ID and BLS public key from an avalanchego node.

Accepts --ip (IP or IP:port) or the global --rpc-url flag.
When both are provided, --ip takes precedence.`,
RunE: func(cmd *cobra.Command, args []string) error {
ctx, cancel := getOperationContext()
defer cancel()

if nodeIP == "" {
return fmt.Errorf("--ip is required")
addr := nodeIP
if addr == "" && customRPCURL != "" {
addr = customRPCURL
}
if addr == "" {
return fmt.Errorf("--ip or --rpc-url is required")
}

info, err := node.GetNodeInfoWithInsecureHTTP(ctx, nodeIP, allowInsecureHTTP)
info, err := node.GetNodeInfoWithInsecureHTTP(ctx, addr, allowInsecureHTTP)
if err != nil {
return fmt.Errorf("failed to get node info: %w", err)
}
Expand All @@ -43,5 +50,5 @@ func init() {
rootCmd.AddCommand(nodeCmd)
nodeCmd.AddCommand(nodeInfoCmd)

nodeInfoCmd.Flags().StringVar(&nodeIP, "ip", "", "Node IP address")
nodeInfoCmd.Flags().StringVar(&nodeIP, "ip", "", "Node IP or IP:port (also accepts --rpc-url)")
}
Loading