Skip to content

Revert "chore: ungate web-search commands (#1558)"#1567

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:revert-web-search-un-gate
Jun 17, 2026
Merged

Revert "chore: ungate web-search commands (#1558)"#1567
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:revert-web-search-un-gate

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 6bb2ca4.

adding a gateway crashes the TUI when no gateway is present.
image

#1568

Testing

now coming soon:
image

@github-actions github-actions Bot added the size/s PR size: S label Jun 17, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 17, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 17, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.20.0.tgz

How to install

gh release download pr-1567-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.0.tgz

@Hweinstock Hweinstock marked this pull request as ready for review June 17, 2026 22:30
@Hweinstock Hweinstock requested a review from a team June 17, 2026 22:30

@agentcore-cli-automation agentcore-cli-automation left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this is a clean, complete revert of #1558 — diffing the PR head against the parent of the original commit shows zero changes. The gating logic is restored consistently across:

  • GatewayTargetPrimitive.ts--type web-search runtime check, --exclude-domains option help-hiding, top-level add web-search / remove web-search shortcut commands hidden + rejected.
  • AddScreen.tsx — Web Search list item disabled with "Coming soon".
  • AddGatewayTargetScreen.tsxwebSearch target type disabled in the picker.
  • AddScreen.test.tsx — "Coming soon" assertion restored.

No serious issues found. Looks good to merge.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 17, 2026
@Hweinstock Hweinstock merged commit b096181 into aws:main Jun 17, 2026
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants