Skip to content

fix(secretsmanager): correct SAR rotation app versions for GovCloud - #38462

Draft
aemada-aws wants to merge 1 commit into
aws:mainfrom
aemada-aws:fix/secretsmanager-govcloud-sar-versions
Draft

fix(secretsmanager): correct SAR rotation app versions for GovCloud#38462
aemada-aws wants to merge 1 commit into
aws:mainfrom
aemada-aws:fix/secretsmanager-govcloud-sar-versions

Conversation

@aemada-aws

Copy link
Copy Markdown
Collaborator

Issue

The aws-us-gov semantic versions pinned for the SecretsManager secret-rotation serverless applications reference versions that are not published in the GovCloud (us-gov-west-1) SAR catalog. Any stack that uses SecretRotation in GovCloud fails at change-set creation when the SAM transform runs, e.g.:

Application arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSMySQLRotationSingleUser does not have a version 1.1.397

This affects all engines (MySQL, PostgreSQL, MariaDB, Oracle, SQL Server, Redshift, MongoDB, Db2) in both single- and multi-user schemes.

Description of changes

Update the aws-us-gov version for every rotation application in secret-rotation.ts to the latest version actually published in the GovCloud SAR catalog:

Application old new
SecretsManagerRDSMariaDBRotationSingleUser 1.1.399 1.1.383
SecretsManagerRDSMariaDBRotationMultiUser 1.1.398 1.1.383
SecretsManagerRDSMySQLRotationSingleUser 1.1.397 1.1.384
SecretsManagerRDSMySQLRotationMultiUser 1.1.397 1.1.383
SecretsManagerRDSOracleRotationSingleUser 1.1.398 1.1.382
SecretsManagerRDSOracleRotationMultiUser 1.1.398 1.1.383
SecretsManagerRDSPostgreSQLRotationSingleUser 1.1.397 1.1.383
SecretsManagerRDSPostgreSQLRotationMultiUser 1.1.397 1.1.383
SecretsManagerRDSSQLServerRotationSingleUser 1.1.398 1.1.383
SecretsManagerRDSSQLServerRotationMultiUser 1.1.398 1.1.384
SecretsManagerRedshiftRotationSingleUser 1.1.398 1.1.383
SecretsManagerRedshiftRotationMultiUser 1.1.397 1.1.383
SecretsManagerMongoDBRotationSingleUser 1.1.397 1.1.384
SecretsManagerMongoDBRotationMultiUser 1.1.398 1.1.384
SecretsManagerRDSDb2RotationSingleUser 1.1.199 1.1.222
SecretsManagerRDSDb2RotationMultiUser 1.1.197 1.1.223

The aws and aws-cn versions are unchanged. Affected integration test snapshots (RDS cluster-rotation, RDS cluster-snapshot, DocDB cluster-rotation) are updated to reflect the new GovCloud version.

Why no feature flag

Adding synth-time changes to versions normally warrants a feature flag when it alters previously-working behavior. Here the old aws-us-gov versions never deployed successfully in GovCloud (the referenced SAR versions do not exist), so this is a fail-forward bug fix and no feature flag is required.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The `aws-us-gov` semantic versions for the SecretsManager rotation
serverless applications point to versions that are not published in the
GovCloud (us-gov-west-1) SAR catalog. This causes the SAM transform to
fail at change-set creation with errors such as:

    Application arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSMySQLRotationSingleUser does not have a version 1.1.397

Update every rotation application's `aws-us-gov` version to the latest
version actually published in the GovCloud SAR catalog. The `aws` and
`aws-cn` versions are unchanged.

These versions were never deployable in GovCloud, so no feature flag is
required.
@github-actions github-actions Bot added the p2 label Jul 31, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team July 31, 2026 14:42
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Jul 31, 2026
@mergify
mergify Bot temporarily deployed to automation July 31, 2026 14:42 Inactive
@mergify
mergify Bot temporarily deployed to automation July 31, 2026 14:42 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

👋 It looks like your PR description follows the template but is missing a valid issue number in the first section.

PRs without a linked issue will receive lower priority for review and merging. Please update the description to include a reference like Closes #123. If no existing issue matches your change, create one first.

@aws-cdk-automation aws-cdk-automation left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants