Skip to content

fix(secretsmanager): correct SAR rotation app versions for GovCloud #38462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aemada-aws wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(secretsmanager): correct SAR rotation app versions for GovCloud #38462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../test/integ.cluster-rotation.lit.js.snapshot/aws-cdk-docdb-cluster-rotation.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@
},
"aws-us-gov": {
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerMongoDBRotationSingleUser",
"semanticVersion": "1.1.397"
"semanticVersion": "1.1.384"
}
}
},
Expand Down
4 changes: 2 additions & 2 deletions ...ds/test/integ.cluster-rotation.lit.js.snapshot/aws-cdk-rds-cluster-rotation.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,7 +1212,7 @@
},
"aws-us-gov": {
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSMySQLRotationSingleUser",
"semanticVersion": "1.1.397"
"semanticVersion": "1.1.384"
}
},
"CustomRotationOptionsRotationSingleUserSARMapping635D6F45": {
Expand All @@ -1226,7 +1226,7 @@
},
"aws-us-gov": {
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSMySQLRotationSingleUser",
"semanticVersion": "1.1.397"
"semanticVersion": "1.1.384"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion ...ws-rds/test/integ.cluster-snapshot.js.snapshot/aws-cdk-rds-cluster-snapshot.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2156,7 +2156,7 @@
},
"aws-us-gov": {
"applicationId": "arn:aws-us-gov:serverlessrepo:us-gov-west-1:023102451235:applications/SecretsManagerRDSMySQLRotationSingleUser",
"semanticVersion": "1.1.397"
"semanticVersion": "1.1.384"
}
}
},
Expand Down
32 changes: 16 additions & 16 deletions packages/aws-cdk-lib/aws-secretsmanager/lib/secret-rotation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class SecretRotationApplication {
public static readonly MARIADB_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRDSMariaDBRotationSingleUser', '1.1.670', {
additionalSemanticVersions: {
'aws-cn': '1.1.442',
'aws-us-gov': '1.1.399',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -47,7 +47,7 @@ export class SecretRotationApplication {
public static readonly MARIADB_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRDSMariaDBRotationMultiUser', '1.1.670', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -57,7 +57,7 @@ export class SecretRotationApplication {
public static readonly MYSQL_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRDSMySQLRotationSingleUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.440',
'aws-us-gov': '1.1.397',
'aws-us-gov': '1.1.384',
},
});

Expand All @@ -67,7 +67,7 @@ export class SecretRotationApplication {
public static readonly MYSQL_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRDSMySQLRotationMultiUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.440',
'aws-us-gov': '1.1.397',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -77,7 +77,7 @@ export class SecretRotationApplication {
public static readonly ORACLE_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRDSOracleRotationSingleUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.382',
},
});

Expand All @@ -87,7 +87,7 @@ export class SecretRotationApplication {
public static readonly ORACLE_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRDSOracleRotationMultiUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -97,7 +97,7 @@ export class SecretRotationApplication {
public static readonly POSTGRES_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRDSPostgreSQLRotationSingleUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.440',
'aws-us-gov': '1.1.397',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -107,7 +107,7 @@ export class SecretRotationApplication {
public static readonly POSTGRES_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRDSPostgreSQLRotationMultiUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.440',
'aws-us-gov': '1.1.397',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -117,7 +117,7 @@ export class SecretRotationApplication {
public static readonly SQLSERVER_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRDSSQLServerRotationSingleUser', '1.1.670', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -127,7 +127,7 @@ export class SecretRotationApplication {
public static readonly SQLSERVER_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRDSSQLServerRotationMultiUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.384',
},
});

Expand All @@ -137,7 +137,7 @@ export class SecretRotationApplication {
public static readonly REDSHIFT_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRedshiftRotationSingleUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -147,7 +147,7 @@ export class SecretRotationApplication {
public static readonly REDSHIFT_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRedshiftRotationMultiUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.440',
'aws-us-gov': '1.1.397',
'aws-us-gov': '1.1.383',
},
});

Expand All @@ -157,7 +157,7 @@ export class SecretRotationApplication {
public static readonly MONGODB_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerMongoDBRotationSingleUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.440',
'aws-us-gov': '1.1.397',
'aws-us-gov': '1.1.384',
},
});

Expand All @@ -167,7 +167,7 @@ export class SecretRotationApplication {
public static readonly MONGODB_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerMongoDBRotationMultiUser', '1.1.671', {
additionalSemanticVersions: {
'aws-cn': '1.1.441',
'aws-us-gov': '1.1.398',
'aws-us-gov': '1.1.384',
},
});

Expand All @@ -177,7 +177,7 @@ export class SecretRotationApplication {
public static readonly DB2_ROTATION_SINGLE_USER = new SecretRotationApplication('SecretsManagerRDSDb2RotationSingleUser', '1.1.271', {
additionalSemanticVersions: {
'aws-cn': '1.1.242',
'aws-us-gov': '1.1.199',
'aws-us-gov': '1.1.222',
},
});

Expand All @@ -187,7 +187,7 @@ export class SecretRotationApplication {
public static readonly DB2_ROTATION_MULTI_USER = new SecretRotationApplication('SecretsManagerRDSDb2RotationMultiUser', '1.1.272', {
additionalSemanticVersions: {
'aws-cn': '1.1.240',
'aws-us-gov': '1.1.197',
'aws-us-gov': '1.1.223',
},
});

Expand Down
Loading